search

nengo / nengo-extras

Extra utilities and add-ons for Nengo
https://www.nengo.ai/nengo-extras
Other
5 stars 8 forks source link

Add NumbaLIF neuron model #86

Closed drasmuss closed 5 years ago

drasmuss commented 5 years ago

Migrated from https://github.com/nengo/nengo/pull/1482

I also reworked the setup.py extra_requires slightly, since I needed to add in numba and there wasn't an obvious place to put it. Could revert this if we want to keep requirements separated by different subcomponents (e.g. one for deeplearning, one for numbalif). But I figured it'd be ok to lump everything under "optional", and that's familiar for people working with other nengo projects.

Based on https://github.com/nengo/nengo-extras/pull/85, as there are some fixes in that branch needed to get nengo-extras tests passing.

hunse commented 5 years ago

Don't know why this didn't close automatically, it's merged and the merged branch is up to date with master.

tbekolay commented 5 years ago

It's because the base branch for this PR isn't master, it's realtime

hunse commented 5 years ago

Ahh, and that's why it wouldn't let me delete the realtime branch earlier. I just thought this was rebased onto realtime, not a PR into realtime.