Reset pan and zoom on autolayout

nengo / nengo-gui

Nengo interactive visualizer

Other

95 stars 38 forks source link

Reset pan and zoom on autolayout #1009

Closed astoeckel closed 5 years ago

astoeckel commented 5 years ago

Previously, when applying an autolayout, the object coordinates were rescaled such that they fit the current viewport taking pan and zoom into account.

Unfortunately, this causes (a) numerical instability due to exponentially exploding/imploding coordinates, (b) issues with scale-dependent objects such as the multi-connection arcs I'm currently implementing.

This PR resets pan and zoom instead of rescaling the coordinates in a new "feedforward_layout_done" message handler. Since this would also change the coordinates of the non-netgraph components, the transformation inverse to the pan/zoom reset is applied to these components.

astoeckel commented 5 years ago

Just to add some more context: one quite quickly ends up with config files like these:

_viz_config[_viz_0].x = 2.787297689367216e+26
_viz_config[_viz_0].y = 2.0661282308455743e+26
_viz_config[_viz_0].width = 1.0907455255117949e+26
_viz_config[_viz_0].height = 1.466644177044316e+26

At which point the interact library does weird stuff, e.g., resizing objects no longer works properly. This PR prevents this from happening.

tcstewar commented 5 years ago

Great catch! Thank you for finding this! It's been merged. :)