Fix `connection_kind` in Nengo 3.0

nengo / nengo-gui

Nengo interactive visualizer

Other

95 stars 38 forks source link

Fix `connection_kind` in Nengo 3.0 #1010

Closed astoeckel closed 5 years ago

astoeckel commented 5 years ago

Connection kind detection broke with Nengo 3.0 and the introduction of multiple transformation kinds. test_netgraph.py exits with failures.

This patch fixes this issue in a backwards-compatible manner by checking for the presence of Nengo 3.0 and accessing the transfomation in the correct way.

You can reproduce this issue by running

pytest --noconftest nengo_gui/tests/test_netgraph.py

Note: this PR is similar to #1004 but is (I think) a little cleaner.

astoeckel commented 5 years ago

As noted in the corresponding PR, #1012 also includes this PR. However, #1012 is far more extensive, hence I'm leaving this open.

tcstewar commented 5 years ago

This has now been merged. Thank you!