search

nengo / nengo-gui

Nengo interactive visualizer
Other
95 stars 38 forks source link

Fix broken sliders given recent nengo.Process API change #1019

Closed tcstewar closed 4 years ago

tcstewar commented 4 years ago

The current master version of nengo causes nengo-gui to break if you run a model and have a slider.

Here's the commit that broke things:

https://github.com/nengo/nengo/commit/e4ac75f8cc4b140b892e765226049e393b5e07bd

(it changes the Process API, and nengo-gui uses a Process to implement the sliders)

This fix is backwards-compatible and continues to work with older nengo versions.

tcstewar commented 4 years ago

@tbekolay if you could quickly double-check that I'm interpretting the new API correctly then I can quickly merge this :)