search

nengo / nengo-gui

Nengo interactive visualizer
Other
95 stars 38 forks source link

InlineGUI depends on notebook package #1028

Open arvoelke opened 4 years ago

arvoelke commented 4 years ago

Describe the bug

Importing InlineGUI within a jupyter notebook can trigger a ModuleNotFoundError due to missing notebook package.

To reproduce

Steps to reproduce the behavior:

  1. Install jupyter
  2. Launch jupyter
  3. In a separate environment, install nengo-gui and ipykernel
  4. Add the nengo-gui environment as a jupyter ipykernel, e.g., python -m ipykernel install --user --name nengo-gui --display-name "Nengo-GUI" if nengo-gui is the name of the environment containing NengoGUI.
  5. In jupyter, select the nengo-gui kernel, and run: 
    
import nengo
model = nengo.Network()

from nengo_gui.ipython import InlineGUI InlineGUI(model)



**Expected behavior**

I expected no error. Perhaps `pip install nengo-gui[optional]` should pull in the `notebook`. Or there should be instructions for using `InlineGUI` somewhere.

**Screenshots**

N/A

**Versions**

 - OS: N/A
 - Browser: N/A
 - Nengo GUI: 0.4.6
 - Other: N/A

**Additional context**

Using `conda` on a relatively fresh environment with `conda install jupyter`, and then adding the kernel to jupyter.