search

nengo / nengo-gui

Nengo interactive visualizer
Other
95 stars 38 forks source link

Fix collections for Python 3.8 and higher #1037

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

See https://stackoverflow.com/questions/53978542/how-to-use-collections-abc-from-both-python-3-8-and-python-2-7/53978543#53978543 - collections.Iterable is not available anymore for Python 3.8 and higher.

jgosmann commented 2 years ago

Is Nengo GUI still targeting Python versions <3.3? Otherwise, it should suffice to always import from collections.abc, keeping the code a bit simpler.

astoeckel commented 2 years ago

I agree with @jgosmann. I've opened an alternative PR at #1040. Thank you for opening the PR nonetheless!