search

nengo / nengo-gui

Nengo interactive visualizer
Other
97 stars 38 forks source link

Decide on target browser(s) and format all code accordingly #63

Closed cchan987 closed 7 years ago

cchan987 commented 9 years ago

change VIZ.set_transform to be compatible with all browsers

tcstewar commented 7 years ago

For reference, I think this is the current implementation of this function

https://github.com/nengo/nengo_gui/blob/master/nengo_gui/static/nengo.js#L26

Nengo.set_transform = function(element, x, y) {
    element.style.webkitTransform =
        element.style.transform = 'translate(' + x + 'px, ' + y + 'px)';
};

I believe this is currently the correct cross-platform way to do it, and it doesn't seem too overly complex to me. But we should check one are the platforms that still require the webkitTransform part.

tcstewar commented 7 years ago

After the dev meeting discussion, I think we're okay on this for now, and it'll also be simplified in the ongoing refactoring. Also, that refactoring will eventually force us to be explicit about exactly what browsers we are allowing.