Ensure things happen in consistent order

nengo / nengo-loihi

Run Nengo models on Intel's Loihi chip

https://www.nengo.ai/nengo-loihi/

Other

35 stars 12 forks source link

Ensure things happen in consistent order #151

Closed hunse closed 5 years ago

hunse commented 5 years ago

Splitter preserves object order from original network.
Host/chip receivers are always called in same order.

This makes sure that seeds are always set the same as well. Right now, setting a seed on a network does not actually guarantee it will be the same from one run to the next, because the splitter dictionaries change the order that everything gets built in in a non-deterministic way.

hunse commented 5 years ago

I also can't think of a test that is non-trivial. Maybe #70 will test some of this, though also the point of #70 was to make sure that things have the same seeds as Nengo no matter what order they're built in.

I've addressed the comments and added a changelog.

tbekolay commented 5 years ago

From the review: we should add a test that splits a model multiple times and ensures that their order in the split networks is the same.

hunse commented 5 years ago

I will write this test.

hunse commented 5 years ago

Ok, I've added a test. I've tested that it can distinguish between before this PR and after it.