Test probes - Githubissues

nengo / nengo-loihi

Run Nengo models on Intel's Loihi chip

https://www.nengo.ai/nengo-loihi/

Other

35 stars 12 forks source link

Test probes #169

Closed hunse closed 5 years ago

hunse commented 5 years ago

This adds a test for neuron input (current) probes, which were not working correctly (due to negative values not being cast correctly, and integers not being filtered correctly). This also corrects both these issues.

TODO:

[x] Add a test for voltage probes as well. The voltage should go negative, to test that we're dealing with negatives correctly. Do we currently allow min_voltage < 0 for e.g. LIF neurons?

hunse commented 5 years ago

Addressed the requested changes. I've also added changelogs for both the probe fixes and the min_voltage.

hunse commented 5 years ago

Fixups look good to me.