Allow 'same' padding for convolution

nengo / nengo-loihi

Run Nengo models on Intel's Loihi chip

https://www.nengo.ai/nengo-loihi/

Other

35 stars 12 forks source link

Allow 'same' padding for convolution #297

Closed hunse closed 2 years ago

hunse commented 3 years ago

This allows "same" padding to be used with nengo.Convolution.

TODO:

[x] More testing (e.g. in test_conv_deepnet)

hunse commented 3 years ago

Added an error for the case shown in #298

hunse commented 3 years ago

This depends on #296

hunse commented 3 years ago

Requires nengo/nengo#1648 for the fix to npconv2d padding for the test, so I think it's easier to just merge this as part of #300.

tbekolay commented 2 years ago

It's still intermittently failing and/or stalling, but I'm at least convinced that it's (mostly) INRC environment issues, so I'm going to merge regardless. We can clean up any issues when all the v1.1.0 PRs are in.