nenosinc / iCloudDocumentSync

Integrate iCloud into iOS document projects with one-line code methods. Sync, upload, manage, and remove documents from iCloud quickly and easily. Helps to make iCloud "just work" for developers too.
Other
1.22k stars 178 forks source link

Really slow in Xcode 9 / iOS 11 #118

Open dpacchi86 opened 6 years ago

dpacchi86 commented 6 years ago

This library worked like a charm under xcode 8 and iOS 10, now that I opened the project with Xcode 9 and iOS 11 iCloud sync is really slow and blocks the main thread a lot. I already have tried many approaches like dispatching on a different thread (Not possible by the iCloud API) and trying to make as few syncs as possible... What could it be? Thanks!

Keith-Hon commented 6 years ago

I have the same issues, did you manage to resolve that?

dpacchi86 commented 6 years ago

Hi

I haven’t really.. I rolled back to a previous version of the library and wiped out my app iCloud container. That seems to have fasten things up like they were before but It’s not a real solution to the problem.

Bye Dario

Il giorno 23 mag 2018, alle ore 09:29, Keith Hon notifications@github.com ha scritto:

I have the same issues, did you manage to resolve that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iRareMedia/iCloudDocumentSync/issues/118#issuecomment-391248508, or mute the thread https://github.com/notifications/unsubscribe-auth/AIk-WNC7i5qwJV4eTvw2A-N3EOs_G5l5ks5t1Q_2gaJpZM4UGqp2.

Keith-Hon commented 6 years ago

it's real slow if user has a large amount of files to sync

dpacchi86 commented 6 years ago

Exactly, even if you have to sync just 1 file but you have hundreds on the cloud it’s slow. I don’t know what to do honestly…

Il giorno 23 mag 2018, alle ore 09:41, Keith Hon notifications@github.com ha scritto:

it's real slow if user has a large amount of files to sync

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iRareMedia/iCloudDocumentSync/issues/118#issuecomment-391251528, or mute the thread https://github.com/notifications/unsubscribe-auth/AIk-WIjwAuUOsdmIQE6CiUnF0Veb9tnqks5t1RKbgaJpZM4UGqp2.

kundanjadhav commented 6 years ago

How did you rolled back to previous version? @dpacchi86

kundanjadhav commented 6 years ago

I have made some code changes in iCloud.m. If anybody need it please let me know.

ongkuanpin commented 6 years ago

I have made some code changes in iCloud.m. If anybody need it please let me know.

can send me the iCloud.m file? my email address is ongkuanpin@gmail.com

Thanks.

robertmanea commented 5 years ago

I have made some code changes in iCloud.m. If anybody need it please let me know.

@kundanjadhav @ongkuanpin Do you still have the file? Could really use it, my address is robert1manea@gmail.com

kundanjadhav commented 5 years ago

@robertmanea and @ongkuanpin sorry for late responding guys. PFA icloud.m.zip

robertmanea commented 5 years ago

@robertmanea and @ongkuanpin sorry for late responding guys. PFA icloud.m.zip

Thanks a ton. Do you have any idea how to tell when all files are finished in the enumerate block? Asking because it's kinda dragging on, so I was thinking of adding a loading indicator up til it's done. I know we have the [iCloudFilesDidChange: withNewFileNames:] delegate method, but it's not consistent (just tested and only got half of my files if I retrieve immediately after this is called).

Sam-Spencer commented 5 years ago

See recent changes from PR #95, which should fix some of these issues.