search

nens / lizard-catalogue

Lizard Catalogue
https://demo.lizard.net/catalogue/
0 stars 0 forks source link

For exporting timeseries export: selecting negative interval should not be allowed. #231

Closed Derryrover closed 3 years ago

Derryrover commented 3 years ago

Here I can select a negative interval when exporting timeseries, that is: start is after end: https://nxt3.staging.lizard.net/catalogue/?data=Timeseries&uuid=0026cda8-5497-4496-9a76-1c18b81c895c

Derryrover commented 3 years ago

@daanvaningen @lexvand @joeriverheijden

Hi Joeri and Lex, Daan notified me of this that negative interval can be selected when exporting timeseries. Could you assign a priority?

kr Tom

joeriverheijden commented 3 years ago

I think it's best to pick this up when you're going to work on the time period filter in the catalogue.

Op ma 7 dec. 2020 om 11:28 schreef Tom de Boer notifications@github.com:

@daanvaningen https://github.com/daanvaningen @lexvand https://github.com/lexvand @joeriverheijden https://github.com/joeriverheijden

Hi Joeri and Lex, Daan notified me of this that negative interval can be selected when exporting timeseries. Could you assign a priority?

kr Tom

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nens/lizard-catalogue/issues/231#issuecomment-739827331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELLJSDOHCEPRP4UZHALW53STSU6JANCNFSM4UQH4VGA .

--

Met vriendelijke groet / Kind regards,

Joeri Verheijden

Product Manager Nelen & Schuurmans

+31 (0)30 233 0200 | +31 (0)6 21586741 www.nelen-schuurmans.nl Lizard https://www.lizard.net/ 3Di https://www.3diwatermanagement.com/ Zakkendragershof 34-44, 3511AE, Utrecht [image: Logo N&S] [image: twitter] https://twitter.com/nelenschuurmans [image: linkedin] https://www.linkedin.com/company/245070/

Derryrover commented 3 years ago

reviewed as part of https://github.com/nens/lizard-catalogue/issues/220

GeOdin commented 3 years ago

@hoanphungt

Hey Hoan :)

I was wondering something. If you select a start time before an end time, you can still press the 'export time series' button. You do get a red error message below the start and end time saying that start should be before end.

If no start time is given (whether or not there is an end time given), the 'export time series' button is disabled. Wouldn't it be nice to also disable this button if start time is before end time?

Let me know if that would also be possible/ needed/ desired.

Kind regards, Madeleine

hoanphungt commented 3 years ago

@GeOdin Hi Madeleine,

Nice observation! It's true that in that case, the button should be disabled as well. I will update it. Thanks for finding out! :)

hoanphungt commented 3 years ago

@GeOdin I fixed this one as part of the other ticket: https://app.zenhub.com/workspaces/team-frontend-5ede33ae05991b2798f63255/issues/nens/lizard-catalogue/220 under this PR: https://github.com/nens/lizard-catalogue/pull/240. So for this one, I will put it to DONE.