nens / lizard-catalogue

Lizard Catalogue
https://demo.lizard.net/catalogue/
0 stars 0 forks source link

Improve export timeseries workflow (experienced as a bug) #254

Closed lisannewapstra closed 3 years ago

lisannewapstra commented 3 years ago

Via Joeri

Original Topdesk Ticket Joeri - 2102 0163 Fwd: inloggen in validatietool meetreeksbeheer

image

Hi, De exportknop in de catalogus licht niet groen op als je bent ingelogd en is daarmee niet beschikbaar voor de gebruiker. Ik denk dat dit verband houdt met die nieuwe manier van inloggen. Mag met hoge prio opgepakt worden door het team.

Analysis Support

I do not think it has to do with being logged in. And it also works with rasters. For timeseries, there seems to be a Start time required.

With Start image

Without start image

Is this by design?

lexvand commented 3 years ago

What needs to be done to make this work for users:

lexvand commented 3 years ago

@LirryPinter Can you adjust the design with this second modal?

LirryPinter commented 3 years ago

Modal with:

LirryPinter commented 3 years ago

Design is updated.

Added a modal for selection the period for the export!

@lexvand @hoanphungt

hoanphungt commented 3 years ago

Design link: https://xd.adobe.com/view/2ca9bb91-e3f0-45c8-bc17-a0f15a4dfefc-79fa/screen/3cee670d-a5b2-4ef4-a6dd-1392c3a41ea3/specs/

hoanphungt commented 3 years ago

@Derryrover Hi Tom,

Could you review this PR: https://github.com/nens/lizard-catalogue/pull/255/? Design link is in the above comment.

Kr, Hoan

Derryrover commented 3 years ago

@hoanphungt

Hi Hoan,

Overall looks and works good. Ready to merge

2 notes:

kr Tom

hoanphungt commented 3 years ago

@lexvand @joeriverheijden Hi Joeri and Lex,

I think Tom's above comment makes sense here. Adding another modal on top of the timeseries selection modal seems to be quite cumbersome since it hides some of the information in the other modal. However, since I already made it, I think it would be best if I put it on staging and let you two and @LirryPinter experiment with this to see the pros and cons compared to the previous exporting method.

Kr, Hoan