search

nens / lizard-catalogue

Lizard Catalogue
https://demo.lizard.net/catalogue/
0 stars 0 forks source link

Refactor MainApp, Header and FilterBar components to hooks components #258

Closed hoanphungt closed 3 years ago

Derryrover commented 3 years ago

@hoanphungt

Hi Hoan,

I think this is a very good initiative! Liked how you refactored this.

I approved, because i see no code problems and also no bugs. But I find it hard to oversee all the details.

Maybe we must advice some more intense testing before going to prod? How do you think?

kr Tom

hoanphungt commented 3 years ago

@Derryrover Yes I agree.

@lexvand Hi Lex, it would be nice if you can perform some intensive tests for this change. Mostly about if data is still loaded correctly (e.g. observation types, organisations, rasters, wms layers, monitoring networks, locations, timeseries) and if the URL is updated correctly with the filter selections.

lexvand commented 3 years ago

Can't find any problems related to this while testing.