Closed remcogerlich closed 2 years ago
@remcogerlich I added 2 more tasks for this ticket as updated in the description. That's why I increase the story point from 2 to 3.
@remcogerlich
Regarding the npm audit
issue, you can use yarn audit
instead of npm audit
since the repo is setup by using yarn
. If we want to run npm audit
then we first need to create the package-lock.json file by running this command: npm i --package-lock-only
. Thi will only create the package-lock.json file without installing anything. Then we can use npm audit
and npm audit fix
. So I actually didn't have to do anything to genarate the audit report for the catalogue repo and both yarn audit
and npm audit
gave me the same audit result (2 moderate vulnerables).
Test on staging: Can't find any bugs.
See the Regular maintenance Excel sheet in the Frontend team ( https://nelenschuurmans.sharepoint.com/:x:/s/IT/EZGwogcDfPBLhG7q5_F0zqoBLA1XCWtKgPfLrjEuOlXJXg?e=qz17qV )
Version updates for lizard-catalogue:
Fix the small number of 'any' annotations in the code.
This has the same issue with 'npm' and running 'npm audit' as lizard-management-client does; hopefully, if it is fixed in one, the same fix works for the other.
This project was at some point ejected with 'create-react-app eject', because I told Hoan that was a good idea, at the time. It wasn't, that means we have to manage many more dependencies by hand. We need to undo it by creating a new directory by hand and moving everything relevant into that. That is probably what's going to cost some time for this repo, but I'm not sure if 1 day or 2 days is right.
Tasks:
create-react-app
again and manually copying the code over to the new directoryany
annotations in the codenpm
andnpm audit
(if not done in the lizard-management-client yet)