nens / servicedesk-issue-only

This repository will be used primarily by the service desk to report issues which will then be moved by the teamleads
0 stars 0 forks source link

[3Di]: Cannot set any date (not for radar rain and not for forecast rain) (staging) #134

Closed GeOdin closed 1 year ago

GeOdin commented 1 year ago

Contact Details

No response

Topdesk URL (API)

No response

Incident Type

Error

What priority should we assign to this submission?

Prio2 Urgent

3Di component

Livesite

What happened?

I could not pick a date with the datetime picker (for a radar/ forecast rain).

How to Reproduce?

Open a browser (happens on Chrome/ Firefox and Edge) Select and start a model (for example v2_bergermeer_with_grndwtr #111 and template with_grndwtr Select rain in the left toolbar Select radar or forecast Try to select another date/time (I tried to look for 28 July 2014 via selecting on the year and then the year range, but I think selecting any date and/ or time causes the issue). You get undefined and NaN as date and time (and Invalid date in input field)

If you press undefined NaN in the datetime dialog, it crashes

What did you expect and what was the actual result?

I expected that I could use the date time picker to pick a date

Add screenshots, video's etc

Click on a date

20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - click on 28

Option 1 from here

You get invalid date Go back to not crash (click outside dialog) 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - dont click on undefined NaN

Option 2

You get invalid date. Click on invalid date to get 4rd screenshot. 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - click on 28 - invalid date - click on it

Clicked on invalid date 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - click on 28 - invalid date - clicked on it

Go back to not crash (click outside dialog) 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - dont click on undefined NaN

Option 3 crash

Click on undefined NaN in dialog (top) 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - click on undefined NaN to crash

Crash 20230104 - 3di staging - datum selectie 28 juli 2014 bij bergermeer - error when crashing

Relevant log output

main.a69ceab633eaf0f4.js:2 TypeError: Cannot read properties of undefined (reading 'substring')
    at r.value (main.a69ceab633eaf0f4.js:2:5094321)
    at r.value (main.a69ceab633eaf0f4.js:2:5093979)
    at r.value (main.a69ceab633eaf0f4.js:2:5093439)
    at r.value (main.a69ceab633eaf0f4.js:2:5093006)
    at Rs (main.a69ceab633eaf0f4.js:2:5268883)
    at As (main.a69ceab633eaf0f4.js:2:5268681)
    at kl (main.a69ceab633eaf0f4.js:2:5312152)
    at _u (main.a69ceab633eaf0f4.js:2:5300185)
    at vu (main.a69ceab633eaf0f4.js:2:5300113)
    at gu (main.a69ceab633eaf0f4.js:2:5299976)
hs @ main.a69ceab633eaf0f4.js:2
n.callback @ main.a69ceab633eaf0f4.js:2
Fo @ main.a69ceab633eaf0f4.js:2
bl @ main.a69ceab633eaf0f4.js:2
_l @ main.a69ceab633eaf0f4.js:2
yl @ main.a69ceab633eaf0f4.js:2
(anonymous) @ main.a69ceab633eaf0f4.js:2
xu @ main.a69ceab633eaf0f4.js:2
lu @ main.a69ceab633eaf0f4.js:2
Ur @ main.a69ceab633eaf0f4.js:2
(anonymous) @ main.a69ceab633eaf0f4.js:2
main.a69ceab633eaf0f4.js:2 Uncaught TypeError: Cannot read properties of undefined (reading 'substring')
    at r.value (main.a69ceab633eaf0f4.js:2:5094321)
    at r.value (main.a69ceab633eaf0f4.js:2:5093979)
    at r.value (main.a69ceab633eaf0f4.js:2:5093439)
    at r.value (main.a69ceab633eaf0f4.js:2:5093006)
    at Rs (main.a69ceab633eaf0f4.js:2:5268883)
    at As (main.a69ceab633eaf0f4.js:2:5268681)
    at kl (main.a69ceab633eaf0f4.js:2:5312152)
    at _u (main.a69ceab633eaf0f4.js:2:5300185)
    at vu (main.a69ceab633eaf0f4.js:2:5300113)
    at gu (main.a69ceab633eaf0f4.js:2:5299976)

Additional info

Note: does not happen on production (Chrome) (yet). So it probably has something to do with recent changes in staging.

Did the date time for Lizard recently changed (and is it not yet adjusted to work with the datetime picker)? Is a new version used for the datetime picker on staging?

Another note: just changing the time does work!

Good luck! :)

GeOdin commented 1 year ago

@Patrick-Nijman

Hey Patrick :)

I gave this ticket priority 2 because it currently only is on staging. But it is something a lot of people will notice without workaround (I think).

I did the same for https://github.com/nens/servicedesk-issue-only/issues/135

Kind regards

GeOdin commented 1 year ago

Another note: clicking on a date in the datetime picker always causes the input field (in the rain tool, outside the datetimepicker) to show Invalid date (also for all options).

GeOdin commented 1 year ago

Note this happens when selecting any date in the datetime picker.

For example, when not changing the date, you can create a radar rain.

20230130 - 3di staging - create radar rain without changing date

The rain is applied.

20230130 - 3di staging - radar rain applied

But when you select any date, even if it is just the same date (the date of yesterday in this example), you get NaN and undefined for dates and time. I only clicked on the date in the date input field and then clicked on 29 in the example below.

20230130 - 3di staging - datepicker also NaN when today and applied from when not changing data

20230130 - 3di staging - datepicker also NaN when today and applied from when not changing data 2 datepicker not defined

Patrick-Nijman commented 1 year ago

Opgelost voor de release van 6 feb.