nens / threedi-api-qgis-client

3Di Models & Simulations plugin
https://plugins.lizard.net/
Other
2 stars 0 forks source link

Download gridadmin geopackage if available #438

Closed leendertvanwolfswinkel closed 1 year ago

leendertvanwolfswinkel commented 1 year ago

When downloading a schematisation revision, it is currently already checked if a valid model for this revision is available and if so, the gridadmin.h5 file is downloaded.

We now have a new endpoint from which the GIS representation of the gridadmin (in GeoPackage format) can be downloaded:

/v3/threedimodels/{id}/geopackage/download/

Please download this file as well (to the same folder as the gridadmin.h5) if it is available. If it is not available, make sure the process continues without errors.

ldebek commented 1 year ago

@leendertvanwolfswinkel Looks like a threedi-api-client with a new endpoint support is not released on PyPi yet. I would need it released first to finalize this ticket and prepare PR.

leendertvanwolfswinkel commented 1 year ago

I have notified @jpprins1 of this, I expect a new threedi-api-client to be released soon

leendertvanwolfswinkel commented 1 year ago

@ldebek The real release of threedi-api-client will have to wait until it is released onto production, but a beta release has been made available https://pypi.org/project/threedi-api-client/4.1.2b0/

ldebek commented 1 year ago

@leendertvanwolfswinkel Changes available for testing on branch: https://github.com/nens/threedi-api-qgis-client/tree/downloading_gridadmin_geopackage

leendertvanwolfswinkel commented 1 year ago

The requested features all work as they should. However I now realize I want some more and some changes (sorry for the feature creep...):

ldebek commented 1 year ago

@leendertvanwolfswinkel Change requested above applied.