No longer store gridadmin files in `work in progress` folder

nens / threedi-api-qgis-client

3Di Models & Simulations plugin

https://plugins.lizard.net/

Other

2 stars 0 forks source link

No longer store gridadmin files in `work in progress` folder #449

Closed leendertvanwolfswinkel closed 3 days ago

leendertvanwolfswinkel commented 1 year ago

[x] When downloading a revision to the work in progress folder, the rasters and sqlite should be downloaded to that folder (because they are editable), but the gridadmin.h5 and gridadmin.gpkg should be downloaded to revision {nr}\grid (because they are read-only)
[x] The folder work in progress\grid should no longer be created, it is not used for anything

leendertvanwolfswinkel commented 3 weeks ago

@ldebek I tested this and both items work as they should

While testing I realised that the work in progress\results folder is also never used, so should also not be created. Sorry for that...

ldebek commented 3 weeks ago

@leendertvanwolfswinkel Done.

leendertvanwolfswinkel commented 2 weeks ago

@ldebek I tested (made a new schematisation) but the work_in_progress\results folder is still there:

ldebek commented 2 weeks ago

@leendertvanwolfswinkel Did you update threedi-mi-utils to version 0.1.4 ?

leendertvanwolfswinkel commented 2 weeks ago

Well no I just updated the plugin (and restarted QGIS), shouldn't that be enough? Or are there other plugins that are also shipped with threedi-mi-utils as dep?

ldebek commented 2 weeks ago

@leendertvanwolfswinkel threedi-mi-utils is shipped with ThreeDiToolbox as well, so if you have that one installed then M&S plugin will use older version. To avoid confusion I made a PR for the toolbox as well: https://github.com/nens/threedi-results-analysis/pull/1038

leendertvanwolfswinkel commented 2 weeks ago

Ah yes now it works. Please merge both PRs @ldebek