Simulation wizard: Improve Laterals page

[leendertvanwolfswinkel]

The current UI does not correspond with the possible use cases for laterals. Proposed UI:

• [x] The whole group "1D laterals" should be disabled if there is no 1D in the threedimodel

• [x] "[ ] Use 1D laterals from simulation template" should be disabled if there are no 1D laterals in the simulation template

• [x] "[ ] Use 1D laterals from simulation template" should be enabled and checked if there are 1D laterals in the simulation template

• [x] The whole group "2D laterals" should be disabled if there is no 2D in the threedimodel

• [x] "[ ] Use 2D laterals from simulation template" should be disabled if there are no 2D laterals in the simulation template

• [x] "[ ] Use 2D laterals from simulation template" should be enabled and checked if there are 2D laterals in the simulation template

[leendertvanwolfswinkel]

@leendertvanwolfswinkel Check if units in spatialite are converted from minutes to seconds somehow? There was a ticket for this (weird vague thing)

[hoanphungt]

@leendertvanwolfswinkel is it possible to select both 1d laterals and 2d laterals or only one of them is allowed? Previously, there is a dropdown to select 1d or 2d laterals so I thought only one of them can be selected at one time.

[leendertvanwolfswinkel]

@hoanphungt this is one of the main reasons to re-implement this page. It is a perfectly valid option to have both 1D and 2D laterals in your simulation, but the current UI implementation won't allow you to do this

[hoanphungt]

For this bullet:

• The whole group "1D laterals" should be disabled if there is no 1D in the threedimodel

How do I know if there is no 1D / 2D in the 3di model?

Answer: if the 3di model contains extent_one_D or extent_two_D

And similarly for this bullet:

• Use 1D laterals from simulation template" should be disabled if there are no 1D laterals in the simulation template

How do I know if there is 1D / 2D laterals in the simulation template?

Answer: if there is "point" key in the laterals => 2D else it's 1D

[hoanphungt]

@leendertvanwolfswinkel I am going pretty far with this laterals page. There are still a few more questions for you though:

1. the use 1d / 2d laterals from simulation template option: does it inherit the events.laterals from the simulation template or events.filelaterals? This option is not available in the old laterals page.

2. Can you elaborate more on the Add to existing and Replace existing options for 1D laterals? By default, which option should be selected first or are they both optional?

[leendertvanwolfswinkel]

@hoanphungt 1: if the user says "from template", it should be exactly the same as the template. So both the events.laterals and the events.filelaterals. 2: Let's make our lives a bit simpler and remove this choice. The behaviour should just be that if the user checks both the "Use laterals from simulation template" and "Upload laterals" option, the uploaded laterals are added to the ones from the simulation template. You can just post to the same endpoint multple times for laterals, iirc.

[leendertvanwolfswinkel]

@hoanphungt I tested it and have the following feedback:

• [x] When checking the "interpolate" box for 1D laterals, I get the following error:

TypeError: 'str' object does not support item assignment 
Traceback (most recent call last):
  File "C:\Users\leendert.vanwolfswin\AppData\Roaming\3Di\QGIS3\profiles\default/python/plugins\threedi_models_and_simulations\widgets\simulation_wizard.py", line 635, in interpolate_changed
    val["interpolate"] = interpolate
TypeError: 'str' object does not support item assignment

• [x] I tried with a 1D and 2D lateral. The files are these:

laterals 2D with type and XY (AS_XY) geometry in WGS84 poging 3.csv

laterals 1d.csv

They are accepted by the validation that occurs directly after selecting the file. However, when I try to start the simulation, I get this error:

NotImplementedError 
Traceback (most recent call last):
  File "C:\Users\leendert.vanwolfswin\AppData\Roaming\3Di\QGIS3\profiles\default/python/plugins\threedi_models_and_simulations\widgets\simulation_wizard.py", line 2972, in run_new_simulation
    constant_laterals, file_laterals = self.laterals_page.main_widget.get_laterals_data(
  File "C:\Users\leendert.vanwolfswin\AppData\Roaming\3Di\QGIS3\profiles\default/python/plugins\threedi_models_and_simulations\widgets\simulation_wizard.py", line 689, in get_laterals_data
    file_laterals.update(self.recalculate_laterals_timeseries(self.TYPE_1D, timesteps_in_seconds))
  File "C:\Users\leendert.vanwolfswin\AppData\Roaming\3Di\QGIS3\profiles\default/python/plugins\threedi_models_and_simulations\widgets\simulation_wizard.py", line 667, in recalculate_laterals_timeseries
    raise NotImplementedError
NotImplementedError

[hoanphungt]

@leendertvanwolfswinkel I fixed both errors. Could you please try again?

[hoanphungt]

The 2d laterals file should have columns in the following order:

X Y type id timeseries

[hoanphungt]

@leendertvanwolfswinkel this issue can be tested again on the master branch

[leendertvanwolfswinkel]

@hoanphungt I have tested again. I am now able to upload both 1D and 2D laterals in the same simulation.

However, my input is:

• 3 2D laterals (IDs 1, 2, 3)
• 4 1D laterals (IDs 1, 2, 3, 4)

What the API says it has received:

• 3 2D laterals (ID 1, 2, 3)
• 1 1D lateral (ID 4)

So the 1D laterals with IDs 1, 2, and 3 are missing.

Model: Akersloot (Leendert) #3 1D laterals CSV: laterals_1d.csv

2D laterals CSV: laterals_2d_x_y_id_timeseries_wgs84.csv

[leendertvanwolfswinkel]

@hoanphungt one more minor design issue. I noticed that the "1D laterals" header looks different (I think just smaller font size) than the 2D laterals header. Please make them both the same as the 2D laterals header

[hoanphungt]

@hoanphungt I have tested again. I am now able to upload both 1D and 2D laterals in the same simulation.

However, my input is:

• 3 2D laterals (IDs 1, 2, 3)
• 4 1D laterals (IDs 1, 2, 3, 4)

What the API says it has received:

• 3 2D laterals (ID 1, 2, 3)
• 1 1D lateral (ID 4)

So the 1D laterals with IDs 1, 2, and 3 are missing.

Model: Akersloot (Leendert) #3 1D laterals CSV: laterals_1d.csv

2D laterals CSV: laterals_2d_x_y_id_timeseries_wgs84.csv

@leendertvanwolfswinkel It seems that laterals 1d and 2d can have the same id indeed. I didn't know about it. Can you test again in this PR: https://github.com/nens/threedi-api-qgis-client/pull/555?

[leendertvanwolfswinkel]

@hoanphungt tested it again and it works as expected. Please also fix the minor design issue mentioned in my previous comment and merge to master

[hoanphungt]

@leendertvanwolfswinkel I don't have the minor design issue that you mentioned so that's strange.