Simulation wizard: Rain "Stop after" value is not read correctly from simulation template

[leendertvanwolfswinkel]

This simulation template has a constant rain event that starts after 1 hour and stops after 2 hours: https://management.3di.live/simulations/153434

But when loaded in the Simulation Wizard, it says "stop after 1 hour":

Private Zenhub Image

[ldebek]

@leendertvanwolfswinkel In the current implementation stop after should be meant as a duration of the rain counted since "start after" time. Would you like to change it in a way that it will be reffered as a period of the simulation duration?

[leendertvanwolfswinkel]

Ok wow I have always misunderstood this than. And all other users as well.

Easiest fix would be to simple change the text to "Rain duration" I guess

Verzonden vanaf Outlook voor Androidhttps://aka.ms/AAb9ysg

---

From: Lukasz Debek @.> Sent: Thursday, October 5, 2023 5:18:43 PM To: nens/threedi-api-qgis-client @.> Cc: Leendert van Wolfswinkel @.>; Mention @.> Subject: Re: [nens/threedi-api-qgis-client] Simulation wizard: Rain "Stop after" value is not read correctly from simulation template (Issue #498)

@leendertvanwolfswinkelhttps://github.com/leendertvanwolfswinkel In the current implementation stop after should be meant as a duration of the rain counted since "start after" time. Would you like to change it in a way that it will be reffered as a period of the simulation duration?

— Reply to this email directly, view it on GitHubhttps://github.com/nens/threedi-api-qgis-client/issues/498#issuecomment-1749116917, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGICNK4RYR7ZTCVPNOUEPK3X53FVHAVCNFSM6AAAAAA5RB5FX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGEYTMOJRG4. You are receiving this because you were mentioned.Message ID: @.***>

[leendertvanwolfswinkel]

I think what adds to the confusing is the ordering of the widgets ("Start after" and "Stop after" on the same line, suggesting something like "from - to").

Better to have

Start after: [ ] [units] Duration: [ ] [units] Intensity: [ mm/h]

And yes please apply the same to wind

Met vriendelijke groet / Kind regards,

Leendert van Wolfswinkel

Consultant Water Management

Nelen & Schuurmans

Werkdagen: ma di wo do | Working Days: Mon Tue Wed Thu

+31 (0)30 233 0200 <tel:+31+(0)30+233+0200> | +31 (0)6 <tel:+31+(0)6+----+----> 31 000 353 www.nelen-schuurmans.nl Zakkendragershof 34-44, 3511AE, Utrecht [Logo N&S] [twitter]https://twitter.com/nelenschuurmans [linkedin] https://www.linkedin.com/company/245070/

---

Van: Lukasz Debek @.> Verzonden: vrijdag 6 oktober 2023 14:19 Aan: nens/threedi-api-qgis-client @.> CC: Leendert van Wolfswinkel @.>; Mention @.> Onderwerp: Re: [nens/threedi-api-qgis-client] Simulation wizard: Rain "Stop after" value is not read correctly from simulation template (Issue #498)

@leendertvanwolfswinkelhttps://github.com/leendertvanwolfswinkel That's probably the cleanest and easiest option. Same should be applied to wind, right?

— Reply to this email directly, view it on GitHubhttps://github.com/nens/threedi-api-qgis-client/issues/498#issuecomment-1750545670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGICNK3OZWRMX5RZYYEWUTDX57ZLLAVCNFSM6AAAAAA5RB5FX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGU2DKNRXGA. You are receiving this because you were mentioned.Message ID: @.***>

[ldebek]

@leendertvanwolfswinkel I double checked again, and I was wrong in my comment yesterday - stop after indeed reffers to the simulation duration and there is a bug in the way of reading template data. Sorry for the confusion.

[leendertvanwolfswinkel]

tested, can be merged 👍