nens / threedi-api-qgis-client

3Di Models & Simulations plugin
https://plugins.lizard.net/
Other
2 stars 0 forks source link

Simulation wizard: Add substance concentrations section to Laterals page #538

Closed leendertvanwolfswinkel closed 4 months ago

leendertvanwolfswinkel commented 7 months ago

Mockup:

image.png

Change in design:

Example script:

simulate.zip

hoanphungt commented 5 months ago

Better to wait for #545 and #547 to be merged first to avoid lots of conflicts.

hoanphungt commented 5 months ago

@leendertvanwolfswinkel

Regarding this point:

there should be multiple file inputs for different types of substances that have been defined in the Substances page for 1D / 2D

I think instead of having 2 file inputs for each substance for 1D and 2D, we only need 1 file input for both of them. That's simpler. What do you think?

The csv file format for the substance concentrations file should look like this:

id | timeseries

in which id is the lateral id and timeseries is the substance concentrations

leendertvanwolfswinkel commented 4 months ago

@hoanphungt that would not be correct, because it is possible to have a 1D lateral with ID 23 and a 2D lateral with id 23 in the same simulation, I think?

hoanphungt commented 4 months ago

@leendertvanwolfswinkel You are right! It's possible to have 1d and 2d laterals with the same id. I updated the UI.

leendertvanwolfswinkel commented 4 months ago

Hi @hoanphungt you can merge the water_quality branch to master!