search

nens / threedi-api-qgis-client

3Di Models & Simulations plugin
https://plugins.lizard.net/
Other
2 stars 0 forks source link

Download failed due to the following error: '>' not supported between instances of 'NoneType' and 'float' #578

Open Jonasvsl opened 4 weeks ago

Jonasvsl commented 4 weeks ago
image.png

When downloading this dataset via de lizard plugin:

image.png
ldebek commented 3 weeks ago

@Jonasvsl @leendertvanwolfswinkel Issue was caused by the fact that raster instance was missing origin, upper_bound and pixelsize information. As a workaround set fallback raster resolution value to 1.0.

ldebek commented 3 weeks ago

PR: https://github.com/nens/lizard-qgis-plugin/pull/33

leendertvanwolfswinkel commented 2 weeks ago

I tested it and it seems to work correctly.

However, the mentioned fallback value for the raster resolution is not filled in in the raster resolution widget, which is a bit confusing.

image.png

One thing I was wondering: What is supposed to happen if the chosen pixel size is 0? Same for when the selected CRS is "Invalid CRS". Perhaps we should not allow this? I.e. show a message when the user clicks "accept"?

ldebek commented 2 weeks ago

I tested it and it seems to work correctly.

However, the mentioned fallback value for the raster resolution is not filled in in the raster resolution widget, which is a bit confusing.

image.png

One thing I was wondering: What is supposed to happen if the chosen pixel size is 0? Same for when the selected CRS is "Invalid CRS". Perhaps we should not allow this? I.e. show a message when the user clicks "accept"?

If pixel size is 0 then it will be calculated based on raster metadata pixelsize. If projection is invalid then there is no projection assigned to the raster task.

ldebek commented 2 weeks ago

Added adjustments to the raster resolution widget.

leendertvanwolfswinkel commented 1 week ago

@ldebek tested, please merge