search

nens / threedi-modelchecker

Tool to verify the correctness of a 3Di model
MIT License
0 stars 2 forks source link

Simulation template extract (and API save) robustness #151

Open jpprins1 opened 2 years ago

jpprins1 commented 2 years ago

Some schematisations have incorrect laterals/boundaries/structure controls or maybe other things that do not pass the validation (for example: shihmen_project_cw has incorrect laterals)

In this case the simulation template worker should not use these parts and only process what does work.

Jonasvsl commented 1 year ago

@jpprins1 is the correct repo for this ticket?

jpprins1 commented 1 year ago

@Jonasvsl: Is this something that we (still) want?

It might be deceiving for an user to get a template which does not include everything that he/she expects... Because in practice this means that all events that do not pass validation are deleted before the simulation is 'promoted' to a template.

Note: we could fix this by adding some status/error field to the template, this information needs to be shown everywhere the template is used.