search

nens / threedi-modelchecker

Tool to verify the correctness of a 3Di model
MIT License
0 stars 2 forks source link

Check if pipe or culvert has Open Rectangle (shape = 1) #335

Closed leendertvanwolfswinkel closed 1 year ago

leendertvanwolfswinkel commented 1 year ago

If v2_pipe or v2_culvert has shape = 1 (open rectangle), please give the following message (INFO level):

"Cross-section shape "open rectangle" (1) is unusual for pipes and culverts. Perhaps you meant to use "closed rectangle" (2)?"

elisalle commented 1 year ago

@leendertvanwolfswinkel why only rectangles? perhaps this should be checked on all open profiles as defined in #323 and calculated in https://github.com/nens/threedi-modelchecker/blob/e9045ec3db2683cd321b6a1f8b704ed02df8d6ca/threedi_modelchecker/checks/cross_section_definitions.py#L326-L395?

leendertvanwolfswinkel commented 1 year ago

@elisallenens yes that is a great suggestion. New message:

"This feature has an open cross-section, which is unusual for pipes and culverts. Please make sure this is not a mistake."