nens / threedi-modelchecker

Tool to verify the correctness of a 3Di model
MIT License
0 stars 2 forks source link

Support schema 300 (settings) #366

Closed margrietpalm closed 4 months ago

margrietpalm commented 6 months ago

Should be used with latest schema, currently on margriet_46_schema_300!

Apologies for the large number of changes. Most changes just involve rename tables and or columns. But due to the changes in the schema, some checks have been modified, removed or added. Please see the comments I made in this PR for some extra context.

In this updated version the settings tables, except AggregationSettings, have exactly one row. The migration takes care of enforcing this and retaining the correct settings. Previously, filters for the first row of GlobalSetting and matching setting table rows were created and the checks were only performed on that data. This machinery has been removed because there should be only one row.

The integration tests ensure that the results of the model checker are unchanged, except for expected results due to the schema changes.