nens / threedi-schema

The schema of 3Di schematization files
MIT License
0 stars 0 forks source link

Remove measure_variable from memory_control and table_control #97

Closed leendertvanwolfswinkel closed 1 month ago

leendertvanwolfswinkel commented 2 months ago

In the spreadsheet for the structure control migration, the attribute "measure_variable" is used 3 times:

This was a mistake; what it should be is:

If I am not mistaken, the template worker only uses control_measure_location.measure_variable, so no changes in the template worker are required in that case

margrietpalm commented 2 months ago

Also requires API changes: https://app.zenhub.com/workspaces/team-3di-5ef60eff1973dd0024268b90/issues/gh/nens/threedi-api/2322

margrietpalm commented 2 months ago

Currently implemented as hotfix for 224. But work on released API may be more complicated, so maybe consider releasing this as seperate migration.

margrietpalm commented 2 months ago

Hmm, I find this very confusing. Linking the variable to the location, but the other parameters to the ControlTable or ControlMemory. So for example, the threshold for memory control is set in ControlMemory, but the actual variable it is linked to is linked to the location. However, without knowing the variable, a value like threshold makes no sense.

Also, this seems to require a lot of work in the template worker.

margrietpalm commented 2 months ago

Rename:

margrietpalm commented 2 months ago

Seperate migration (227?)

margrietpalm commented 2 months ago

In schema ControlMeasureMap and ControlMeasureLocation are still used, maybe rename those as well