Add support for point geometries source data to "import culverts/weirs/orifices"

[leendertvanwolfswinkel]

I would like to release the "import point structures" tool that was developed as part of the MIKE importer separately. For users, Integrating it in the "Import culverts" algorithm would make workflows for users the easiest. I propose to add five arguments to the "conversion settings" section of the config JSON (and to the GUI once that is finished):

{
  "target_layer": "culvert",
  "conversion_settings": {
    "use_snapping": true,
    "snapping_distance": 0.5,
    "create_connection_nodes": true, 
    "length_source_field": "duiker_lengte", NEW
    "length_fallback_value": 10, NEW
    "azimuth_source_field": "duiker_richting", NEW
    "azimuth_fallback_value": 90, NEW
    "edit_channels": true NEW
  },

• The length_source_field contains the name of the field in the source layer that contains the length that the line feature should have. This can also be None. This setting is ignored when the input has a line geometry.

• The length_fallback_value is a float value to be used when length_source_field is None or that attribute is NULL for this specific feature. This setting is ignored when the input has a line geometry.

• If edit_channels is true and the source layer has a point geometry, the behaviour is as in the algorithm that you wrote for the mike converter.

• If edit_channels is true and the source layer has a linestring geometry, and the start and end vertices are both within snapping distance of the same channel, it should work the same as in the algorithm that you wrote for the mike converter. otherwise, use the same logic as already exists in the culvert importer

• If edit_channels is false and the source layer has a point geometry, use the value in azimuth_source_field or if not available azimuth_fallback_value to draw a line. After having the line, the same logic can be applied as already exists in the culvert importer

• If edit_channels is false and the source layer has a line geometry, use the same logic as already exists in the culvert importer

• [ ] Also update the UI

When this has been implemented, we can simply create config files that work for the mike converter intermediate outputs

[ldebek]

Testing data would be very helpful to properly test this functionality.

[leendertvanwolfswinkel]

@ldebek sorry this took so long... this zip contains:

• Dommelerwaard import HyDamo.gpkg --> 3Di Schematisation
• HyDAMO_Dommelerwaard.gpkg --> source data. Use layer "Brug" to import as culverts, layer "Stuw" to import as weir

Dommelerwaard.zip

[leendertvanwolfswinkel]

@ldebek I tested it with the test data and this config json Stuwen importeren als weir.json to import the layer "Stuw" as weir. Feedback:

• [x] The "Length fallback value" is now prepopulated with 10 m, please set this to 1 m instead
• The channels are not cut even though I checked the "edit channels" box
• 
• If I add an extra weir to the source data that is close to another weir (< length), they are overlapping. I think I remember the algorithm for the MIKE importer took care of this? Perhaps related to the "edit channels" thing not working?
• If the weir is close to the start or end of the channel, it may result in short segments (see image below). Also for this, iirc this was also taken care of in the algorithm for the MIKE importer? Perhaps this is also dysfunctional because the whole "edit channels" thing does not work? If so, what tolerance is used, i.e. how short is a cut-up channel allowed to be? I would propose to regard any channel segment < 5 m as "too short" and shift the weir to the start/end of the channel in such cases
• 

[leendertvanwolfswinkel]

Hi @ldebek I did some further testing with the new version. The channel editing function now works. I have some further wishes:

• [ ] Improve the way the importer handles structures at junctions. Currently, it creates a structure on each channel that is intersected. So in this case, I get three weirs for the price of one:

The best would be to handle them as follows:

• Snap the point only to the nearest channel

• If there are > 1 nearest channels (exact same distance), do not process the point

• When the import is finished, but some points have been skipped, show a warning telling the user which points where skipped. Would be extra nice if a point layer of "skipped points" could be added to the project

• [ ] When the channel is split, some parts of the channel may end up without a cross-section location. If cutting up the channel results in channels without cross-section locations, please copy the nearest cross-section location from the original channel to that new channel:

• [ ] Remove the new options from the Pipes importer