Support 1D vegetation in Schematisation Editor

[leendertvanwolfswinkel]

In schema version 219, the following new fields where added to the spatialite:

v2_cross_section_location (these are all float fields)

• vegetation_stem_density
• vegetation_stem_diameter
• vegetation_height
• vegetation_drag_coefficient

v2_cross_section_definition (these are all string fields containing space-separated float values)

• friction_values

• vegetation_stem_densities

• vegetation_stem_diameters

• vegetation_heights

• vegetation_drag_coefficients

• [ ] Import/export to spatialite should be added.

• [ ] The attribute form of Cross-section location should be changed as shown in the images below

• [ ] The "friction values per segment" and all vegetation options should only be enabled if cross section shape = YZ and friction_type = Chézy with conveyance.

• [ ] The "friction values per segment" and "vegetation parameters per segment" tables should have 1 fewer row than the "cross-section table"

[leendertvanwolfswinkel]

Feedback:

• [x] Please make the friction, vegetation, and cross-section sections automatically resize in the vertical direction so that it does not show a scrollbar (because we already have a scrollbar for the whole attribute form)
• [x] It should be possible to use a single friction value even if the cross-section shape is YZ
• [x] It should be possible to not use vegetation (leave the parameters empty, or empty them if they are filled)
• [x] It should be possible to use single values for the vegetation parameters, even if the cross-section shape is YZ

Perhaps it would be best to make this all more explicit in the attribute form, using radio buttons and a checkable group for Vegetation. Like this:

[leendertvanwolfswinkel]

I tested your updated version; I think we are almost there. w.r.t. the scrollbars, see my explanation on Slack.

W.r.t. the radio buttons / checkable group idea: I think we can do without it as you mentioned that is is quite complicated to implement. To make it clear to the user how it works, we can just change the text "Friction coefficients per segment" to "Friction coefficients per segment (overrides single friction value)" and "Vegetation parameter per segment" to "Vegetation parameters per segment (overrides single vegetation values)"

However, I found another (important) issue; the vegetation values from v2_cross_section_location are not imported correctly:

And a very minor thing, please add spaces here:

[leendertvanwolfswinkel]

@ldebek I did further testing and had some discussions with my colleague. I have identified the following to do's:

• [x] Tables are cleared, but upon committing the changes, the data comes back. Private Zenhub Video
• [x] I like the more compact view and that you can see 5 rows without scrolling; but I think it would be better that if there are more rows, the scrollbar is shown
• [x] A new version of threedi-schema, 0.219.3 was released today. It correctly regenerates the v2_cross_section_location_view. Please bump the version number in both threedi-schematisation-editor and in this PR of ThreeDiToolbox
• [x] Apparently the logic of which combinations of cross-section shapes, friction types and friction/vegetation parameters are allowed is a bit more complicated than I thought before. This is the full thing, things that need to be changed in bold:

Cross-section shape = YZ

• Chezy:
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters ENABLED
  • Vegetation parameters per segment DISABLED
• Manning:
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED
• Chezy with conveyance:
  • Single friction value ENABLED
  • Friction coefficients per segment ENABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment ENABLED
• Manning with conveyance
  • Single friction value ENABLED
  • Friction coefficients per segment ENABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED

Cross-section shape = Tabulated rectangle, Tabulated trapezium

• Chezy:
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED
• Manning:
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED
• Chezy with conveyance:
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters ENABLED
  • Vegetation parameters per segment DISABLED
• Manning with conveyance
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED

Cross-section shape anything else

• All friction types
  • Single friction value ENABLED
  • Friction coefficients per segment DISABLED
  • Single vegetation parameters DISABLED
  • Vegetation parameters per segment DISABLED

[ldebek]

@leendertvanwolfswinkel Tables are cleared, but upon committing the changes, the data comes back. issue was skipped for a time beign as we discussed.

[ldebek]

@leendertvanwolfswinkel Threedi PR reffers to the threedi-schema 0.219.*, so that shouldn't be any action required (only creation of the fresh build might be needed).

[leendertvanwolfswinkel]

@ldebek ok I re-ran the github action for it. I'll test asap!