Processing algorithm "Manhole bottom level from pipes"

[leendertvanwolfswinkel]

Input

• Manhole layer
• Pipe layer
• Boolean option "overwrite existing bottom levels"
• Boolean option "do not raise existing bottom levels"

Output

• No new layer, just updating the "bottom_level" attribute of the input Manhole layer

Algorithm

• For each manhole, find the adjacent pipe invert levels (e.g. pipe.invert_level_start_point where manhole.connection_node_id == pipe.connection_node_start_id or pipe.invert_level_end_point where manhole.connection_node_id == pipe.connection_node_end_id)
• Calculate the minimum of the adjacent pipe invert levels; if "do not raise existing bottom levels" is True, also include the current bottom level value in the list of values for which you calculate the minimum
• Fill in this value in the manhole layer
• If "overwrite existing values" is False, only run the algorithm for manhole features where Manhole.bottom_level is NULL; else, run it for all manholes

[jordienetten]

Please also for Culverts :-)

[ldebek]

Tool ready for testing on branch: https://github.com/nens/threedi-schematisation-editor/tree/manhole_bottom_level_from_pipes

[leendertvanwolfswinkel]

@ldebek I made a PR from your branch

Some feedback:

• With these settings, manholes with bottom level NULL are not updated:
• If I have a pipe with invert_level_start_point = 2.0 and invert_level_end_point = 3.0, the algo fills in bottom_level = 2.0 for both manholes; the start manholes should get 2.0 and the end manhole 3.0 as bottom level
• Please allow users to choose "selected features only" for both pipes and manholes
• Set "overwrite existing bottom levels" to Unchecked by default
• Remove the . at the end of the algorithm name
• I have reconsidered the name of the group. As there is already a 1D2D group, I think it would be appropriate to call this group "1D"

[leendertvanwolfswinkel]

@jordienetten je kan hetzelfde processing algorithm ook voor Culverts gebruiken, moet je in plaats van Pipes als input gewoon Culverts kiezen.

Opmerking hierbij: De reden om manholes aan begin en eind van culverts te plaatsen is meestal om de calculation type van die nodes op connected te zetten. We zijn momenteel het database-schema aan het herzien; in het nieuwe database schema zit het calculation type (waarschijnlijk) niet meer op de manhole, maar op de _connectionnode. De combinatie culvert/manhole wordt daarmee waarschijnlijk een uitzondering.

[leendertvanwolfswinkel]

@ldebek tested, please merge