nens / threedigrid-builder

Generate a 3Di simulation grid from a model schematisation.
Other
1 stars 0 forks source link

Remove DISTINCT ON in SQLite interface #306

Closed elisalle closed 1 year ago

elisalle commented 1 year ago

In https://github.com/nens/threedigrid-builder/blob/d975af0b0d351456fac6d2ad637f4abcbaf3509a/threedigrid_builder/interface/db.py#L433 a DISTINCT ON clause is used, in case a user has mapped multiple manholes to a single connection node. This throws the following error on running pytest:

SADeprecationWarning: DISTINCT ON is currently supported only by the PostgreSQL dialect.  Use of DISTINCT ON for other backends is currently silently ignored, however this usage is deprecated, and will raise CompileError in a future release for all backends that do not support this syntax.

Since the user isn't supposed to be mapping multiple manholes to a single connection node anyway, the easiest way to solve this is to remove this DISTINCT ON clause. Possibly a check should be added to threedi-modelchecker to check for this.