neo-project / Neo.Cryptography.BLS12_381

MIT License
6 stars 3 forks source link

Converted to dotnet standard 2.1 #6

Closed cschuchardt88 closed 10 months ago

cschuchardt88 commented 10 months ago

@shargon @jim8y @superboyiii

cschuchardt88 commented 10 months ago

@Jim8y should we change the version number? If so to what? 0.3.0? or 1.0.0?

Jim8y commented 10 months ago

Let's use 0.0.3, let erik to decide when to use 1.0.0

Jim8y commented 10 months ago

@shargon

shargon commented 10 months ago

I think that we should use compiler directives, seems that there are a lot of reflection, it will be slower and harder to maintain.

cschuchardt88 commented 10 months ago

@shargon this is the easiest way of doing it, without rewriting a lot of code. Reflection is fast now a days. Just think about all System Attributes in asp.net core and other libraries. They all use reflection for getting attributes

shargon commented 10 months ago

@shargon this is the easiest way of doing it, without rewriting a lot of code. Reflection is fast now a days. Just think about all System Attributes in asp.net core and other libraries. They all use reflection for getting attributes

Maybe we should wait for .net standard 3, why we need it right now?

cschuchardt88 commented 10 months ago

https://github.com/neo-project/neo/pull/3044#issuecomment-1872678538

netstandard2.1 is the last version ever; says microsoft.

shargon commented 10 months ago

netstandard2.1 is the last version ever; says microsoft.

Then this seems like it will not be maintained.

cschuchardt88 commented 10 months ago

You have to understand what netstandard is

.NET Standard allows libraries to build against the agreed
on set of common APIs, ensuring they can be used in any 
.NET application—mobile, desktop, IoT, web, or anywhere you write .NET code.

https://dotnet.microsoft.com/en-us/platform/dotnet-standard#:~:text=NET%20implementations.-,.,NET%20code.

So they would wait for the OS to have some common APIs before they update dotnet standard. But there will still be support and bug fixes

cschuchardt88 commented 10 months ago

My goal in the future is to get neo-core to convert, and have the blockchain run on a phone. Like a lite node. Plus help with developers want to run core or vm on phones or other platforms.

gsmachado commented 10 months ago

My goal in the future is to get neo-core to convert, and have the blockchain run on a phone. Like a lite node. Plus help with developers want to run core or vm on phones or other platforms.

☝️ this would be AWESOME. ❤️

shargon commented 10 months ago

@cschuchardt88 please, could you update the PR?

cschuchardt88 commented 10 months ago

@shargon all done

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 7463345327


Totals Coverage Status
Change from base Build 7457521814: 0.1%
Covered Lines: 2059
Relevant Lines: 2474

💛 - Coveralls
cschuchardt88 commented 10 months ago

Nvm