Remove static methods: Negate

neo-project / Neo.Cryptography.BLS12_381

MIT License

6 stars 3 forks source link

Remove static methods: Negate #7

Closed shargon closed 10 months ago

shargon commented 10 months ago

In order to improve the dotnet standard migration and reduce the risk changes, I want to remove the static methods one by one

In this PR:

Remove public static T operator -(in Ta)

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 7419911485

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.603%

Totals
Change from base Build 3779439269:	0.0%
Covered Lines:	2033
Relevant Lines:	2428

💛 - Coveralls

Jim8y commented 10 months ago

why splitting them can reduce so called risk? what risk are you specifing and how splitting them can reduce them? did you take any special measurement?

shargon commented 10 months ago

why splitting them can reduce so called risk? what risk are you specifing and how splitting them can reduce them? did you take any special measurement?

It's cryptography, we should take care about any change, if the review it's easier, it will be hard to have a mistake

shargon commented 10 months ago

@Jim8y Merge?

shargon commented 10 months ago

Closed in favor of https://github.com/neo-project/Neo.Cryptography.BLS12_381/pull/11