Remove static methods: Size

neo-project / Neo.Cryptography.BLS12_381

MIT License

6 stars 3 forks source link

Remove static methods: Size #8

Closed shargon closed 8 months ago

shargon commented 8 months ago

In order to improve the dotnet standard migration and reduce the risk changes, I want to remove the static methods one by one

In this PR:

Remove INumber.Size

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7420570764

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 81.641%

Totals
Change from base Build 3779439269:	0.04%
Covered Lines:	2034
Relevant Lines:	2428

💛 - Coveralls

cschuchardt88 commented 8 months ago

The Your code is supported in dotnet standard. Please check the #6 and download it or you try converting to 'netstandard2.1. You will find that that the interfaces are the problem. Not static methods, only interfaces can't have static methods. Tons more code was changed than just static methods. I dont see it being a problem or a performance issue. This library is only used in ApplicationEngine for the syscalls. Plus ApplicationEngine uses tons of reflection to call syscall

shargon commented 8 months ago

The Your code is supported in dotnet standard. Please check the #6 and download it or you try converting to 'netstandard2.1. You will find that that the interfaces are the problem. Not static methods, only interfaces can't have static methods. Tons more code was changed than just static methods. I dont see it being a problem or a performance issue. This library is only used in ApplicationEngine for the syscalls. Plus ApplicationEngine uses tons of reflection to call syscall

That's why I want to remove the static methods in the interface.

shargon commented 8 months ago

Closed in favor of https://github.com/neo-project/Neo.Cryptography.BLS12_381/pull/11