Remove Neo Legacy debug adapter from extension package

neo-project / neo-debugger

Neo Smart Contract Debugger for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=ngd-seattle.neo-contract-debug

MIT License

23 stars 17 forks source link

Remove Neo Legacy debug adapter from extension package #157

Closed devhawk closed 2 years ago

devhawk commented 2 years ago

We could save about 8MB in the install package by downloading Neo.Debug2.Adapter tool package from github on first run.

The extension can easily calculate the github release download URL of the adapter from the version info.

Example URL for a 3.1.x extension release: https://github.com/neo-project/neo-debugger/releases/download/3.1.23/Neo.Debug2.Adapter.3.1.23.nupkg

devhawk commented 2 years ago

Note, with the new versioning scheme, prereleases will be published out of master, the VSIX extension will not have the -preview prerelease tag. This implies a need to update logic in extension to not only to download Neo Legacy adapter one first use but also add -preview to version number when inspecting file system for debug adapter tool package as well as for generating Neo Legacy adapter download URL.