update transaction construction examples for latest changes

netlify[bot] commented 2 years ago

Name	Link
Latest commit	2728b79bc288e771a66c66a13d328e312b59e102
Latest deploy log	https://app.netlify.com/sites/clever-mclean-ad3de1/deploys/6252ef38b7c7760009364c17
Deploy Preview	https://deploy-preview-33--clever-mclean-ad3de1.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

apisit commented 2 years ago

Is this update from the latest version of the SDK? If so, Can you provide more info?

kokahunter commented 2 years ago

Yes, I've used Neo.Network.RPC.RpcClient 3.1.0 and .net6.0

Basically i tried out the code snippets but they would not work without following changes:

Utility is an ambiguous referecen between Neo.Utlity and Neo.Network.RPC.Utility, so need to add using Utility = Neo.Network.RPC.Utility;
RpcClient needs to be initialized at least with new URI(...)
Utility.GetScriptHash needs ProtocolSettings as second parameter.
- So either using ProtocolSettings.Default (that is MainNet)
- Or creating own ProtocolSettings with config file
scriptHash.MakeScript("transfer", sender, receiver, 1024, null); was failing in final TX if 4th parameter was not added explicitly
TransactionManagerFactory does only take 1 paramter RpcClient
Contract.CreateMultiSigContract takes a IReadOnlyCollection as input parameter
- Here im not 100% sure how to handle it the best way

Since 3.2.0 is on the way maybe better wait and evaluate again?

kokahunter commented 10 months ago

@dotnet-policy-service agree

neo-project / neo-dev-portal