search

neo-project / neo-devpack-dotnet

NEO Development Pack
MIT License
79 stars 100 forks source link

Native: extend CryptoLib's `verifyWithECDsa` with compatible `NamedCurveHash` argument #1035

Closed AnnaShaleva closed 4 months ago

AnnaShaleva commented 4 months ago

Port protocol-related part of https://github.com/neo-project/neo/pull/3209.

Note, that build and tests are failing because we need to update neo git submodule. We can merge https://github.com/neo-project/neo/pull/3209 firstly, and then update the neo submodule onto the fresh master. Then I'll rebase this PR and check that tests are passed.

Jim8y commented 4 months ago

@AnnaShaleva anna, we are not going to add secp256k1 support here. Core only do verification, no construction.

AnnaShaleva commented 4 months ago

This code is needed for verification only. In https://github.com/neo-project/neo/pull/3209 we extend the native CryptoLib's verifyWithECDsa parameter, so that both Sha256 and Keccak256 hashes may be checked. We need this PR.

AnnaShaleva commented 4 months ago

Can’t be merged yet, I need to update dependencies.

vncoelho commented 4 months ago

I imagined that, fetch git as well

AnnaShaleva commented 4 months ago

Updated, ready for review and merge.