search

neo-project / neo-devpack-dotnet

NEO Development Pack
MIT License
79 stars 100 forks source link

Coveralls and packages update #1046

Closed shargon closed 3 months ago

shargon commented 3 months ago
shargon commented 3 months ago

Standardize this commands as well:

/p:CoverletOutput=${{ github.workspace }}/coverage-join/ \ /p:MergeWith=${{ github.workspace }}/coverage-join/coverage.json \

This will surely avoid us to make mistakes on that with copy and past. Thus, the standard will be default.

I think that save 3 lines in one is not an issue related to this pr

vncoelho commented 3 months ago

I think that save 3 lines in one is not an issue related to this pr

This is aligned with the change you made for the ENV variable for EXCLUDED_FILES.

shargon commented 3 months ago

I think that save 3 lines in one is not an issue related to this pr

This is aligned with the change you made for the ENV variable for EXCLUDED_FILES.

but excluded is the same for all calls, the others it depends if it's the first call, the middle or the last one

vncoelho commented 3 months ago

I think that save 3 lines in one is not an issue related to this pr

This is aligned with the change you made for the ENV variable for EXCLUDED_FILES.

but excluded is the same for all calls, the others it depends if it's the first call, the middle or the last one

just the first, all others need to merge. The first also needs to explicit CoverletOutput.

In the past, we had many problems with that, do you remember? commits trying to change each result everytime. Now we have a standard for this calls and its working.

vncoelho commented 3 months ago

I think that save 3 lines in one is not an issue related to this pr

This is aligned with the change you made for the ENV variable for EXCLUDED_FILES.

but excluded is the same for all calls, the others it depends if it's the first call, the middle or the last one

If you want I can push it here.

vncoelho commented 3 months ago

I think that save 3 lines in one is not an issue related to this pr

This is aligned with the change you made for the ENV variable for EXCLUDED_FILES.

but excluded is the same for all calls, the others it depends if it's the first call, the middle or the last one

If you want I can push it here.

I will solve asap.

vncoelho commented 3 months ago

Commit c1dbb2e unified and removed some "Probably" extra parameters that were duplicated

vncoelho commented 3 months ago

I will just wait test.