TestEngine: Migrate UTS

shargon commented 3 months ago

Problems found:

https://github.com/neo-project/neo-devpack-dotnet/blob/5334d70d8375fb86f8f68554e5f3454ad383a544/tests/Neo.Compiler.CSharp.TestContracts/Contract_Types_ECPoint.cs#L15 this cast is not the expected as ECPoint.ToString, it converts the ECPoint to byte[] representation, and when is decoded, it throw an exception, DecoderFallbackException because is not a valid UTF8 string
I added a permision in https://github.com/neo-project/neo-devpack-dotnet/pull/1060/files#diff-91f0ea4f6691d93c4ed6f90c777c9ea646fad8ba76100f594370b2f609f15dc4R10 because otherwise is not possible to call a created contract, I don't know how it was possible to work before
Added StringInterpreter for set the parse method used for string types.

Jim8y commented 3 months ago

git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree commit -q -F /var/folders/ry/g6fy9gt1599246fzxndmrl700000gn/T/SourceTreeTemp.A0bQto

git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags --set-upstream upstream refs/heads/migrate_uts:refs/heads/migrate_uts Pushing to github.com:neo-project/neo-devpack-dotnet.git ERROR: Permission to neo-project/neo-devpack-dotnet.git denied to Jim8y. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. Completed with errors, see above

Jim8y commented 3 months ago

The issue is that you are trying to convert byte array directly to string. While original code returns buffer, though the return type is string.

shargon commented 3 months ago

The issue is that you are trying to convert byte array directly to string. While original code returns buffer, though the return type is string.

seems weird to me return in a different format if it FAULT

Jim8y commented 3 months ago

The issue is that you are trying to convert byte array directly to string. While original code returns buffer, though the return type is string.

seems weird to me return in a different format if it FAULT

neo does not.really check the return type, neighter will it convert it to specified type, but your test engine has this system. as you can see the original tests, its using getspan then to hex, instead of directly getstring.

Jim8y commented 2 months ago

@shargon

shargon commented 2 months ago

@Jim8y ready to merge

shargon commented 2 months ago

@Jim8y merge?

neo-project / neo-devpack-dotnet

TestEngine: Migrate UTS #1060