Fix: Adding env.secret settings

[Jim8y]

Is your feature request related to a problem? Please describe. This repo requires new or an update to the env.secrets such that we could properly publish new versions.

Describe the solution you'd like The maintainer with permission of updating the repo setting may help us to update the existing sectres or add new secrets.

Additional context None

[Jim8y]

@cschuchardt88 please add more detail here. @shargon may you please check when you are available.

[shargon]

I saw that currently is with "Public repositories" as visibility, it should be accessible to neo-express...

[cschuchardt88]

@shargon error: Missing value for option 'api-key'

dotnet nuget push ./out/Neo.Assertions.*.nupkg --source https://www.myget.org/F/neo/api/v3/index.json --api-key 
  shell: /usr/bin/bash -e {0}
  env:
    CONFIGURATION: Release
    DOTNET_VERSION: 7.0.x
    DOTNET_ROOT: /usr/share/dotnet
    GitAssemblyInformationalVersion: [3](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:3).6.69-preview+61[4](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:4)4[5](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:5)70[6](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:6)[8](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:8)4
    GitBuildVersion: 3.6.6[9](https://github.com/neo-project/neo-express/actions/runs/6999186509/job/19038246339#step:8:9).24900
    GitBuildVersionSimple: 3.6.69
Required argument missing for option: '--api-key'.

Specify --help for a list of available options and commands.
error: Missing value for option 'api-key'

[shargon]

We have MYGET_TOKEN and NUGET_TOKEN as secrets

[cschuchardt88]

I know it was working before. It seems it was removed for this repo or can only run on certain job/step.

[Jim8y]

@shargon the grand master, NUGET_TOKEN is expiring in 5 days.

[Jim8y]

BTW, may you also set pack/pack as not required, @shargon.

[shargon]

@Liaojinghui What's you mean with pack/pack?

[Jim8y]

pack job of the pack workflow is set as required. Cant you modify that from the setting?

[cschuchardt88]

@shargon can we get pack.yml workflow not be required anymore please?

[cschuchardt88]

[shargon]

@Liaojinghui Is deprecated https://docs.github.com/en/actions/using-workflows/required-workflows I think that we must create a ruleset, What does pack do?

[cschuchardt88]

@shargon currently we removed all logic. But what it did do Is, pack nuget packages and publish to github. And any PR could do this. So each time you commit on a PR it would publish to github nuget.

We want different workflows for different file types. We have javascript/typescript, html, tsx and c# we dont need pack pack anymore. We can't cover all these languages in one job.

[shargon]

I removed the required from:

release/v* (Currently applies to 16 branches) And still be required for master-2.x and master

[shargon]

I see that all is merged to master, so I will do the oposite xD

I removed the required from:

release/v* (Currently applies to 16 branches) And still be required for master-2.x and master

[shargon]

@Liaojinghui @cschuchardt88 please check it

[cschuchardt88]

Looks like its removed. We still have to test myget token secrets on pushing to master after #415

[shargon]

Looks like its removed. We still have to test myget token secrets on pushing to master after #415

We have problems with myGet space ... we are trying to deal with it

[cschuchardt88]

@shargon Yes i see it problem on neo repo

But the problem has to do with you uploading to many files at once. You have to break the files into different steps when uploading (each one in each step).

[cschuchardt88]

@shargon can you figure this out please or @NGDAdmin @superboyiii

[shargon]

It takes the organization secret, that is working for neo

[cschuchardt88]

It takes the organization secret, that is working for neo

Ok, I was thinking my-get.

[cschuchardt88]

Resolved