search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

RpcServer:Split methods from service #824

Closed Jim8y closed 6 months ago

Jim8y commented 11 months ago

split server methods from server itself. We are going to add wss and restful service. methods should be reused cross servers

cschuchardt88 commented 11 months ago

Can you or do you think it's a good idea to add GetStore method to all plugins so we can get storage IStore interface they created?

cschuchardt88 commented 11 months ago

Should split up the models in their library as well, this would help a lot, especially for RestServer's implementation of swagger. What do i mean by models? well they would be the class that have ToJson and FromJson methods like in RpcClient for example. This way we can update RpcClient, RpcServer and anything else that needs with this library. Also have a defined definition of the schema/interface to work with.

Jim8y commented 11 months ago

Should split up the models in their library as well, this would help a lot, especially for RestServer's implementation of swagger. What do i mean by models? well they would be the class that have ToJson and FromJson methods like in RpcClient for example. This way we can update RpcClient, RpcServer and anything else that needs with this library. Also have a defined definition of the schema/interface to work with.

I think you already did that in your rest web pr, we can update it with your code after this pr is merged.

Jim8y commented 11 months ago

@shargon Our beloved man, can you please review this pr and help us make it merged, we need this for the wss and restweb