search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

MaxParamsDepth and MaxRequestBodySize in RpcServer #827

Closed shargon closed 10 months ago

shargon commented 11 months ago

Close neo-project/neo#2950

shargon commented 11 months ago

@superboyiii could you test it?

shargon commented 10 months ago

Ping @superboyiii

cschuchardt88 commented 9 months ago

@shargon @Liaojinghui @superboyiii this doesnt fix the problem..... it has to do with a string in a parameter

WitnessCondition keep creating an object, that could eat memory if crafted right

See:

https://github.com/neo-project/neo/blob/4e9314d6b33fb8158e4f2527f889a9cbe7377a73/src/Neo/Network/P2P/Payloads/Conditions/WitnessCondition.cs#L107

https://github.com/neo-project/neo-modules/blob/2d7fb2778ca7ad11815e438534916103859e36ac/src/RpcServer/RpcServer.SmartContract.cs#L175

cschuchardt88 commented 9 months ago

here is an example of what im talking about example.txt

shargon commented 9 months ago

But this

here is an example of what im talking about example.txt

But this send a lot of accounts not Rules, is a different one.