neo-project / neo-modules

MIT License
60 stars 100 forks source link

Add debug mode to the applicationlog to get log info #842

Closed Jim8y closed 6 months ago

Jim8y commented 9 months ago

Closes #841

This pr focus on adding a debug mode to the applicationlog plugin such that developers can get the transaction execution log via the rpc interface.

What has changed?

Will this impact other tools?

No

Jim8y commented 9 months ago

@cschuchardt88 just finished coding, not tested yet, but you can take a look. Will finish it tomorrow.

cschuchardt88 commented 9 months ago

Still need to update RpcClient RpcApplicationLog Class. neo-express uses that for FromJson

shargon commented 9 months ago

Why only during debug? It seems reasonable to get this information always

Jim8y commented 9 months ago

Why only during debug? It seems reasonable to get this information always

This changes the response message size and processing time, without a solid test, i dare not add it directly in fear of DOS attacks. So, debug mode first. But we can also go straightforward to add it for production env if you think it is OK.

vncoelho commented 9 months ago

In this case, test the potential DOS first would be good. And leave as not default for now.

Jim8y commented 9 months ago

@cschuchardt88 this will not be merged until we have a monorepo.

cschuchardt88 commented 9 months ago

@Liaojinghui @vncoelho PR #807 should be able to handle any amount of logs.

@Liaojinghui also im updating PR #807 for these new changes. Can you give an example template of the json? or is it the same as what I posted in #841

Jim8y commented 9 months ago

@Liaojinghui @vncoelho PR #807 should be able to handle any amount of logs.

@Liaojinghui also im updating PR #807 for these new changes. Can you give an example template of the json? or is it the same as what I posted in #841

Exactly the same as you posted