search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

Ensure max length #845

Closed shargon closed 8 months ago

shargon commented 9 months ago

Related to: https://github.com/neo-project/neo-modules/pull/827#issuecomment-1815273757

shargon commented 9 months ago

We can wait for #815

cschuchardt88 commented 9 months ago

have max allowed witness conditions been fixed in neo-core or here? like and boolean not etc

shargon commented 8 months ago

have max allowed witness conditions been fixed in neo-core or here? like and boolean not etc

Must be on both, here is composed manually, not deserialized.

Jim8y commented 8 months ago

@shargon , grand master, can we have a sole project where all limits are set together? the existing limitations are like here and there, hard to follow and track.

shargon commented 8 months ago

@shargon , grand master, can we have a sole project where all limits are set together? the existing limitations are like here and there, hard to follow and track.

Agree, but the limits are during deserialization, and here the object is composed manually, so the nodes are protected, but no the rpc node, I think

shargon commented 8 months ago

I will merge it, #815 is delayed and it can replace this throw later