search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

Refac build configs #846

Closed Ashuaidehao closed 9 months ago

Ashuaidehao commented 9 months ago

Close https://github.com/neo-project/neo-modules/issues/848

Jim8y commented 9 months ago

Why is this pr?

Ashuaidehao commented 9 months ago

Why is this pr?

To prune dotnet publish outputs of neo plugin projects.

shargon commented 9 months ago

Please create an issue or at least describe the problem that you are trying to solve

superboyiii commented 9 months ago

See https://github.com/neo-project/neo-modules/issues/848 @shargon @Liaojinghui

Jim8y commented 9 months ago

Behaves the same as description #848

vncoelho commented 9 months ago

I will compile here and see results.

superboyiii commented 9 months ago

Choose #849 or this? They have the same behaviour.

shargon commented 9 months ago

This was first, isn't it?

Jim8y commented 9 months ago

This was first, isn't it?

Yes

cschuchardt88 commented 9 months ago

however when you dotnet build it will build all the files. and i thought you wanted no dependencies in the output. #849 doesn't have that problem in workflow actions.

Jim8y commented 9 months ago

@Ashuaidehao this breaks the publish process, please check and fix.