neo-project / neo-modules

MIT License
60 stars 100 forks source link

Fix response from getversion due to WS removal #859

Closed vncoelho closed 8 months ago

cschuchardt88 commented 8 months ago

Can you post reminders on RestServer and WebSocketServer PRs?

Jim8y commented 8 months ago

We still have other places that contain wsport, mind to remove them as well?

shargon commented 8 months ago

We still have other places that contain wsport, mind to remove them as well?

If there are more we should remove them together

vncoelho commented 8 months ago

We still have other places that contain wsport, mind to remove them as well?

I am not sure

vncoelho commented 8 months ago

Maybe rpcclient, lets double check

cschuchardt88 commented 8 months ago

Try compiling the whole solution, and check for errors. After you update all the packages.

vncoelho commented 8 months ago

This was not compilation error,@cschuchardt88

cschuchardt88 commented 8 months ago

But if it errors, it will let you know if anymore exist.

vncoelho commented 8 months ago

I was still setting up our tools that creates neo-cli client and add plugins.

I will soon compile again, but since I was able to add the plugin I think that the library does not provide compilation error, just when called. I also added RPCClient to it.

However, thinking about the logic there must be a similar call there. Later I will check.

Jim8y commented 8 months ago

Just do a wsport search you will find them.

cschuchardt88 commented 8 months ago

You want to be searching for ws and websocket

superboyiii commented 8 months ago

62bb544de4aeedba1e708995542dd5a All these should be removed.