neo-project / neo-modules

MIT License
61 stars 102 forks source link

Revert "Added AspNetCore (#863)" #864

Closed vncoelho closed 6 months ago

vncoelho commented 6 months ago

This reverts commit e9e7a07a3e170852b32784c5a48456c63fe55498.

if https://github.com/neo-project/neo/pull/3066 is merged

vncoelho commented 6 months ago

I do not think, so @cschuchardt88 I tried here and there are compilations problems without that change.

cschuchardt88 commented 6 months ago

NVM close this.

This still needs to be done, Because no neo.dll that imports asp.net framework.

vncoelho commented 6 months ago

@shargon, too much instability on that other change. I am still not feeling safe to go.

The changes are requesting too much for the basic environment to build and run a simple client.

cschuchardt88 commented 6 months ago

Let me fix RestServer 1st, and problem gone.

vncoelho commented 6 months ago

I am not in hurry, most of the current working PRs are made by you @cschuchardt88 ....aheuaheuahea As soon as everything is clear it will look good to me. But fell free to move on if you guys fell it is good.

cschuchardt88 commented 6 months ago

It's just user error on your part. I tested everything with and without docker.

Please close. If need a dockerfile i can help you with that its very easy.

image