search

neo-project / neo-modules

MIT License
61 stars 102 forks source link

Missing `wsport` field of `getversion` RPC structure on RPC client side #867

Open AnnaShaleva opened 6 months ago

AnnaShaleva commented 6 months ago

Describe the bug https://github.com/neo-project/neo-modules/pull/859 removed WsPort property from RpcVersion class on the RPC client side. We need to get it back, because NeoGo RPC server still supports WS capability and NeoC# RPC client is capable of interacting with both C# and Go nodes. It's OK not to have this field on the NeoC# RPC server side since WS server was removed form the C# node.

Expected behavior NeoC# RPC client should be able to properly unmarshal wsport field of the response to getversion RPC call.

Platform:

Jim8y commented 6 months ago

Unless C# adds ws support, otherwise Wsport will not be add back.

roman-khimov commented 6 months ago

What's the behavior now? The client will fail unmarshaling the response? Same thing can happen with new client accessing old server, please be careful.