search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

Update core #881

Closed shargon closed 7 months ago

shargon commented 7 months ago

Close https://github.com/neo-project/neo-modules/issues/879 https://github.com/neo-project/neo-modules/issues/880 Require https://github.com/neo-project/neo/pull/3161

vncoelho commented 7 months ago

let me test

shargon commented 7 months ago 
#40 6.697 /opt/neo-modules/src/RpcServer/Utility.cs(38,34): error CS1061: 'NativeContract' does not contain a definition for 'GetContractState' and no accessible extension method 'GetContractState' accepting a first argument of type 'NativeContract' could be found (are you missing a using directive or an assembly reference?) [/opt/neo-modules/src/RpcServer/RpcServer.csproj]

You need to update your submodule, it works in workflow

vncoelho commented 7 months ago

mine is updated

shargon commented 7 months ago

mine is updated

No, is not xD, check the workflow

https://github.com/neo-project/neo/compare/ffa56fe2b28171f86c53ea9912f0c1a4cad9e11a...66ef246beb6bdc4b259cf503e345ff695725ebbb#diff-0c73dead4b3bf99a843db2e553e363772200e2e459f628df62e5a404d9d9f3a5R202

vncoelho commented 7 months ago

My setup is different @shargon

I am obtaining the last neo locally and replacing the folder entirely

# Now it is submodule deps - Removing the existing directory
RUN rm -r /opt/neo-modules/neo
# Copying the new library into place
RUN cp -r /opt/neoLib /opt/neo-modules/neo
# Getting the git version of the module
RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
# Getting the git version of the submodule
RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#37 [33/40] RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
#37 0.324 Current neoLib last commit is: b467613884ef4196283f9f303897dedb0c3de36d
#37 DONE 0.3s

#38 [34/40] RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#38 0.352 Current neo-modules last commit is: 8aaeb5e571c513458f3e2bf4ffcda090576002c3
shargon commented 7 months ago

My setup is different @shargon

I am obtaining the last neo locally and replacing the folder entirely

# Now it is submodule deps - Removing the existing directory
RUN rm -r /opt/neo-modules/neo
# Copying the new library into place
RUN cp -r /opt/neoLib /opt/neo-modules/neo
# Getting the git version of the module
RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
# Getting the git version of the submodule
RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#37 [33/40] RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
#37 0.324 Current neoLib last commit is: b467613884ef4196283f9f303897dedb0c3de36d
#37 DONE 0.3s

#38 [34/40] RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#38 0.352 Current neo-modules last commit is: 8aaeb5e571c513458f3e2bf4ffcda090576002c3

Check that you have this commit in neo 66ef246beb6bdc4b259cf503e345ff695725ebbb https://github.com/neo-project/neo/commit/66ef246beb6bdc4b259cf503e345ff695725ebbb

vncoelho commented 7 months ago

In fact these two were minutes ago....aehauheauea