search

neo-project / neo-modules

MIT License
60 stars 100 forks source link

crlf replaced by lf #892

Closed vncoelho closed 6 months ago

vncoelho commented 6 months ago

close https://github.com/neo-project/neo-modules/issues/891

vncoelho commented 6 months ago

There is a strange error, trying to fix this "corrupted" file

cschuchardt88 commented 6 months ago

@vncoelho Please close PR and do https://github.com/neo-project/neo-modules/issues/891#issuecomment-2016009178

vncoelho commented 6 months ago

I will double check

cschuchardt88 commented 6 months ago

@vncoelho Checkout #893

vncoelho commented 6 months ago

Looks good,but what is the difference from the PR I opened? The file fix looks the same. The other change looks good, is to avoid for future,right?

cschuchardt88 commented 6 months ago

@vncoelho I could not change config.json back to CRLF; see notes below for reason why.

You Add to .gitattributes File

Jim8y commented 6 months ago

@vncoelho the code itself is right, but you have to update your local setting.

vncoelho commented 6 months ago

@vncoelho I could not change config.json back to CRLF; see notes below for reason why.

You Add to .gitattributes File

  • *.json text eol=lf
    • Note: This will automatically normalizes & changes line endings for all *.json files on push/commit.

Great, I was thinking about some change to enforce it. It is great that you found the solution.

vncoelho commented 6 months ago

@vncoelho the code itself is right, but you have to update your local setting.

I do not know what you are trying to say,@vncoelho. The local setting is the same as before.

cschuchardt88 commented 6 months ago

Great, I was thinking about some change to enforce it. It is great that you found the solution.

@vncoelho We had problems last year with this happening; guess I missed a file.

dusmart commented 6 months ago

I faced the same problem, too.

Seems that the crlf are introduced in https://github.com/neo-project/neo-modules/pull/865/files. see git diff -R 79f0d78 origin/master src/ApplicationLogs/config.json

This fix should be sufficient.

cschuchardt88 commented 6 months ago

@vncoelho

vncoelho commented 6 months ago

Soon I will be in the computer as well.

vncoelho commented 6 months ago

@vncoelho

* Add this line `*.json text eol=lf` to `.gitattributes` file for this PR to be complete.

done