Closed Jim8y closed 2 years ago
@erikzhang
tested?
@shargon it works well on my machine.
Tested with two comments:
Tested with two comments:
- when installing OracleService, Grpc.xx dependency files will be added in the zip file, but when uninstall, they will not be removed. when install again, it will show plugin exist, users can use "reinstall OraceService" to solve the problem, while I
@cloud8little unfortunately, we can not uninstall the dependency along with the plugin, because we don't know whether that dependency is also relyed by other plugins.
Tested with two comments:
- when installing OracleService, Grpc.xx dependency files will be added in the zip file, but when uninstall, they will not be removed. when install again, it will show plugin exist, users can use "reinstall OraceService" to solve the problem, while I
@cloud8little unfortunately, we can not uninstall the dependency along with the plugin, because we don't know whether that dependency is also relyed by other plugins.
how about to remind the user to use reinstall command?
@Liaojinghui please help solve the conflict.
tested?
@shargon
Totals | |
---|---|
Change from base Build 2070089971: | 0.0% |
Covered Lines: | 107 |
Relevant Lines: | 683 |
@shargon @erikzhang This pr works together with https://github.com/neo-project/neo-modules/pull/624
https://github.com/neo-project/neo-node/pull/807#discussion_r845920181 with the correct change, all tests passed.
Need to test again.
reinstall StateService cause error:
@shargon @erikzhang Please have a look.
install OracleService and then uninstall, show successful, then install OracleService, it shows error because the Grpc dll already exists, when uninstall, they are not deleted. Then it requires end-user to delete these files by themselves, then install can be successful.
Automatically install plugin depandencies.