neo-project / neo-node

MIT License
229 stars 224 forks source link

Install plugin and dependencies. #807

Closed Jim8y closed 2 years ago

Jim8y commented 3 years ago

Automatically install plugin depandencies.

Jim8y commented 3 years ago

@erikzhang

Jim8y commented 3 years ago

tested?

@shargon it works well on my machine.

cloud8little commented 3 years ago

Tested with two comments:

  1. when installing OracleService, Grpc.xx dependency files will be added in the zip file, but when uninstall, they will not be removed. when install again, it will show plugin exist, users can use "reinstall OraceService" to solve the problem, while I doubt they will use the reinstall command. IMO, in this case, can we remind the user to use reinstall instead?

d7f0cbb0280d384d249c1baa13c38ff

  1. This is not caused by this PR, but I think we should also solve this. Currently install is case-sensitive. Can we make it case-insensitive?

6e736fbfb8b91632130e02f8b64fbdc

Jim8y commented 3 years ago

Tested with two comments:

  1. when installing OracleService, Grpc.xx dependency files will be added in the zip file, but when uninstall, they will not be removed. when install again, it will show plugin exist, users can use "reinstall OraceService" to solve the problem, while I

@cloud8little unfortunately, we can not uninstall the dependency along with the plugin, because we don't know whether that dependency is also relyed by other plugins.

cloud8little commented 3 years ago

Tested with two comments:

  1. when installing OracleService, Grpc.xx dependency files will be added in the zip file, but when uninstall, they will not be removed. when install again, it will show plugin exist, users can use "reinstall OraceService" to solve the problem, while I

@cloud8little unfortunately, we can not uninstall the dependency along with the plugin, because we don't know whether that dependency is also relyed by other plugins.

how about to remind the user to use reinstall command?

cloud8little commented 3 years ago

@Liaojinghui please help solve the conflict.

shargon commented 3 years ago

tested?

Jim8y commented 3 years ago

@shargon

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2164670102


Totals Coverage Status
Change from base Build 2070089971: 0.0%
Covered Lines: 107
Relevant Lines: 683

💛 - Coveralls
Jim8y commented 2 years ago

@shargon @erikzhang This pr works together with https://github.com/neo-project/neo-modules/pull/624

cloud8little commented 2 years ago

https://github.com/neo-project/neo-node/pull/807#discussion_r845920181 with the correct change, all tests passed.

erikzhang commented 2 years ago

Need to test again.

cloud8little commented 2 years ago

18c41be0c7c79b01086d821b815217f

reinstall StateService cause error:

3bd5561d40cdb4b028823c811e9725b

superboyiii commented 2 years ago

@shargon @erikzhang Please have a look.

cloud8little commented 2 years ago

install OracleService and then uninstall, show successful, then install OracleService, it shows error because the Grpc dll already exists, when uninstall, they are not deleted. Then it requires end-user to delete these files by themselves, then install can be successful.

608588bd406b736a21507958173f438